fix dropdown arrow #328
Merged
fix dropdown arrow #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
heartsucker and
redshiftzero
as code owners
sssoleileraaa
force-pushed
the
fix-dropdown
branch
from
e7af2ae to
e67c2ad
Compare
redshiftzero
approved these changes
Apr 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed when testing the client on macOS that the dropdown arrow didn't scale nicely. I thought this was fixed since it looked fine to me on debian. It would be helpful to add future scaling code that can resize without changing aspect ratio of icon images and SVGs. I've seen some useful QImage methods for this, but I don't think we want to have to convert our SvgWidgets or Icons to QImages. I might be wrong, I need more time to research this. For now, I just updated the dropdown arrow so that it can look sharp like the others.
Before
After